[Mellanox] Update Mellanox-SN5600-C256S1, Mellanox-SN5600-C224O8 buffers and DSCP mapping #21427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
noaOrMlnx
force-pushed
the
sn5600-dscp-mapping
branch
from
e8062d0 to
bc5a942
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
approved these changes
Jan 16, 2025
liat-grozovik
approved these changes
Jan 16, 2025
liat-grozovik
changed the title
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…ers and DSCP mapping (sonic-net#21427) - Why I did it To update buffers for Mellanox-SN5600-C256S1 and Mellanox-SN5600-C224O8 - How I did it Update proper files - qos.json.j2, buffer_defaults_objects.j2, buffers_defaults_t0/t1.j2 - How to verify it Run test and check SDK dumps values
11 tasks
11 tasks
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#562 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
|
what is the plan to merge this to 202405 and 202411 branches? @kperumalbfn ? |
11 tasks
|
Cherry-pick PR to 202411: #21693 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Feb 19, 2025
1. Update qos sai lossy tests because all lossless queues has changed as lossy queues 2. Skip fixture reaseAllports for mellanox device, because after qos test is finished, the teardown will do config reload, it will restore the config of ports, we don't need this fixture before running tests. Also it can save 2 minutes 3. Relevant PRs: sonic-net/sonic-buildimage#21427, sonic-net/sonic-buildimage#21056
12 tasks
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Feb 19, 2025
1. Update qos sai lossy tests because all lossless queues has changed as lossy queues 2. Skip fixture reaseAllports for mellanox device, because after qos test is finished, the teardown will do config reload, it will restore the config of ports, we don't need this fixture before running tests. Also it can save 2 minutes 3. Relevant PRs: sonic-net/sonic-buildimage#21427, sonic-net/sonic-buildimage#21056
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Mar 5, 2025
1. Update qos sai lossy tests because all lossless queues has changed as lossy queues 2. Skip fixture reaseAllports for mellanox device, because after qos test is finished, the teardown will do config reload, it will restore the config of ports, we don't need this fixture before running tests. Also it can save 2 minutes 3. Relevant PRs: sonic-net/sonic-buildimage#21427, sonic-net/sonic-buildimage#21056
prabhataravind
pushed a commit
to prabhataravind/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
…ers and DSCP mapping (sonic-net#21427) - Why I did it To update buffers for Mellanox-SN5600-C256S1 and Mellanox-SN5600-C224O8 - How I did it Update proper files - qos.json.j2, buffer_defaults_objects.j2, buffers_defaults_t0/t1.j2 - How to verify it Run test and check SDK dumps values
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2025
Why I did it Some code were deleted by mistake in #21427 Add it back. There are some ports (PIE ports in cisco platform) don't support buffer/qos config, this is to exclude those ports from PORT_ACTIVE to bypass buffer/qos config.
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…ers and DSCP mapping (sonic-net#21427) - Why I did it To update buffers for Mellanox-SN5600-C256S1 and Mellanox-SN5600-C224O8 - How I did it Update proper files - qos.json.j2, buffer_defaults_objects.j2, buffers_defaults_t0/t1.j2 - How to verify it Run test and check SDK dumps values
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
Why I did it Some code were deleted by mistake in sonic-net#21427 Add it back. There are some ports (PIE ports in cisco platform) don't support buffer/qos config, this is to exclude those ports from PORT_ACTIVE to bypass buffer/qos config.
12 tasks
r12f
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Apr 28, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> 1. For spc4 and above, there is only the lossy buffer, so the buffer for the lossless buffer will be taken by the lossy buffer. If the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, which will lead to the descriptor being exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark, and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might raise yang validation error when do config reload 3. When there is no lossless buffer, return a dump buffer lossless pg profile, and skip tests related to lossless buffer case dynamically 4. Skip fixture reaseAllports for mellanox device, because after qos test is finished, the teardown will do config reload, it will restore the config of ports, we don't need this fixture before running tests. Also it can save 2 minutes 5. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#21427 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#21762 Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Add ownership [here](https://msazure.visualstudio.com/AzureWiki/_wiki/wikis/AzureWiki.wiki/744287/TSG-for-ownership-modification)(Microsft required only) - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? update the qos sai test for no pg lossless buffer platform #### How did you do it? update for lossy case and skip test relatd to pg buffer lossless #### How did you verify/test it? Run qos sai test on platform without pg lossless buffer plaform #### Any platform specific information? sn5600 and sn5610 #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To update buffers for Mellanox-SN5600-C256S1 and Mellanox-SN5600-C224O8
Work item tracking
How I did it
Update proper files - qos.json.j2, buffer_defaults_objects.j2, buffers_defaults_t0/t1.j2
How to verify it
Run test and check SDK dumps values
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)