[Mellanox] Update Mellanox-SN5600-C256S1 buffer calculations #20991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprital
approved these changes
Dec 2, 2024
kperumalbfn
reviewed
Dec 10, 2024
| {% set egress_lossless_pool_size = '158229504' %} | ||
| {% set egress_lossy_pool_size = '137779200' %} | ||
| {% set egress_lossy_pool_size = '142703616' %} |
There was a problem hiding this comment.
@noaOrMlnx Are we having both lossless and lossy pool?
liat-grozovik
approved these changes
Dec 12, 2024
|
lossy is small according to the current needs. removing this capability i s not currently support in sonic |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 3, 2025
…et#20991) - Why I did it Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU. - How I did it Update lossless pool - How to verify it Run sonic-mgmt QoS test
|
Cherry-pick PR to 202405: #21328 |
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Jan 10, 2025
1. For spc4, there is only lossy buffer, so the buffer for lossless buffer will be taken by lossy buffer, if the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, so it will lead that descriptor will be exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might rise yang validation error when do config reload 3. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991
12 tasks
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 15, 2025
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…et#20991) - Why I did it Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU. - How I did it Update lossless pool - How to verify it Run sonic-mgmt QoS test
12 tasks
|
Cherry-pick PR to 202411: #21499 |
ayurkiv-nvda
pushed a commit
to ayurkiv-nvda/sonic-buildimage
that referenced
this pull request
Jan 22, 2025
tshalvi
pushed a commit
to tshalvi/sonic-buildimage
that referenced
this pull request
Jan 23, 2025
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jan 27, 2025
mssonicbld
added a commit
that referenced
this pull request
Jan 29, 2025
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 29, 2025
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 29, 2025
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Feb 19, 2025
1. For spc4, there is only lossy buffer, so the buffer for lossless buffer will be taken by lossy buffer, if the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, so it will lead that descriptor will be exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might rise yang validation error when do config reload 3. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Mar 5, 2025
1. For spc4, there is only lossy buffer, so the buffer for lossless buffer will be taken by lossy buffer, if the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, so it will lead that descriptor will be exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might rise yang validation error when do config reload 3. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…et#20991) - Why I did it Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU. - How I did it Update lossless pool - How to verify it Run sonic-mgmt QoS test
12 tasks
r12f
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Apr 28, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> 1. For spc4 and above, there is only the lossy buffer, so the buffer for the lossless buffer will be taken by the lossy buffer. If the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, which will lead to the descriptor being exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark, and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might raise yang validation error when do config reload 3. When there is no lossless buffer, return a dump buffer lossless pg profile, and skip tests related to lossless buffer case dynamically 4. Skip fixture reaseAllports for mellanox device, because after qos test is finished, the teardown will do config reload, it will restore the config of ports, we don't need this fixture before running tests. Also it can save 2 minutes 5. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#21427 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#21762 Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Add ownership [here](https://msazure.visualstudio.com/AzureWiki/_wiki/wikis/AzureWiki.wiki/744287/TSG-for-ownership-modification)(Microsft required only) - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? update the qos sai test for no pg lossless buffer platform #### How did you do it? update for lossy case and skip test relatd to pg buffer lossless #### How did you verify/test it? Run qos sai test on platform without pg lossless buffer plaform #### Any platform specific information? sn5600 and sn5610 #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU.
Work item tracking
How I did it
Update lossless pool
How to verify it
Run sonic-mgmt QoS test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)