Skip to content

Dell S6100 sfputil missing header files. #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Dell S6100 sfputil missing header files. #2117

merged 1 commit into from
Oct 4, 2018

Conversation

paavaanan
Copy link
Contributor

- What I did
get_transceiver_change_event in sfputil.py uses select and logging modules without importing the module.

- How I did it
Imported necessary header modules

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Oct 4, 2018

retest this please

@jleveque
Copy link
Contributor

jleveque commented Oct 4, 2018

I assume this resolves sonic-net/sonic-platform-daemons#18, correct?

@padmanarayana
Copy link
Contributor

yes

@lguohan lguohan merged commit bb8e767 into sonic-net:master Oct 4, 2018
@jleveque jleveque mentioned this pull request Oct 4, 2018
Closed
@paavaanan paavaanan deleted the xcvrd-header-for-s6100 branch May 10, 2020 06:09
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Apr 22, 2022
@stepanblyschak
[sonic-utilities] submodule update
e734afa 
```
22a388b [show] fix get routing stack routine (sonic-net#2137)
cb3a047 Support option --ports of config qos reload for reloading ports' QoS and buffer configuration to default (sonic-net#2125)
154a801 Enhance "config interface type/advertised-type" to be blocked on RJ45 ports  (sonic-net#2112)
3732ac5 Add CLI for route flow counter feature (sonic-net#2031)
29771e7 [techsupport] improve robustness (sonic-net#2117)
f9dc681 [intfutil] Display RJ45 port and portchannel speed in 'M' instead of 'G' when it's <= 1000M (sonic-net#2110)
781ae9f [config] Do not enable pfcwd for BmcMgmtToRRouter (sonic-net#2136)
23e9398 [scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133)
576c9ef [scripts/fast-reboot] stop timers in advance (sonic-net#2131)
4dad79c bugfix: incorrect command for portchannel creation (sonic-net#2134)
c17b1f4 [show][muxcable] Decrease the timeout for show mux status/hwmode (sonic-net#2130)
49d61f8 [scripts/fast-reboot] cleanup (sonic-net#2132)
52ca324 [config/config_mgmt.py]: Fix dpb issue with upper case mac in (sonic-net#2066)
9e2fbf4 Update db_migrator to support `pfcwd_sw_enable` (sonic-net#2087)
4010bd0 FGNHG CLI changes (sonic-net#1588)
6bd54d0 Fix 'show mac' output when FDB entry for default vlan is None instead of 1 (sonic-net#2126)
```

Signed-off-by: Stepan Blyschak <[email protected]>
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Apr 25, 2022
Merged
6 tasks
judyjoseph added a commit that referenced this pull request May 2, 2022
@judyjoseph
Update sonic-swss, sonic-utilities submodules
b3f42fe 
swss
f71c57e [ACL]Avoid incrementing crm count when ACL rule create fails (#2238)

utilities
8a93fde Allow fw update for other boot type against on the previous "none" boot fw update (#2040)
5837559 [show] fix get routing stack routine (#2137)
c888f29 [techsupport] improve robustness (#2117)
liat-grozovik pushed a commit that referenced this pull request May 12, 2022
@Junchao-Mellanox
[submodule] Advance sonic-utilities pointer (#10670)
9887e76 
288c2d8 Revert "[scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)" (#2161)
bce4694 [autoneg] add support for remote speed advertisement (#2124)
a73f156 [show][vrf]Fixing show vrf to include vlan subinterface (#2158)
7a06457 [auto_ts] Enable register/de-register auto_ts config for APP Extension (#2139)
083ebcc Add transceiver-info items advertised for cmis-supported moddules (#2135)
0811214 Validate destination port is not LAG (#2053)
6ab1c51 [minigraph]  Consume golden_config_db.json while loading minigraph (#2140)
c37a957 [Kdump] Remove the duplicate logic if Kdump was disabled (#2128)
1143869 Ordering fix for sfpshow eeprom (#2113)
fdb79b8 Allow fw update for other boot type against on the previous "none" boot fw update (#2040)
a54a091 [GCU] Supressing YANG errors from libyang while sorting (#1991)
fbfa8bc [GCU] Enabling AddRack and adding RemoveRack tests (#2143)
d012be9 [Command-Reference] Add CLI docs for route flow counter (#2069)
8c07d59 [Mellanox] [reboot] [asan] stop asan-enabled containers on reboot (#2107)
697aae3 Fix speed parsing when speed is NOT fetched from APPL_DB (#2138)
22a388b [show] fix get routing stack routine (#2137)
cb3a047 Support option --ports of config qos reload for reloading ports' QoS and buffer configuration to default (#2125)
154a801 Enhance "config interface type/advertised-type" to be blocked on RJ45 ports  (#2112)
3732ac5 Add CLI for route flow counter feature (#2031)
29771e7 [techsupport] improve robustness (#2117)
f9dc681 [intfutil] Display RJ45 port and portchannel speed in 'M' instead of 'G' when it's <= 1000M (#2110)
781ae9f [config] Do not enable pfcwd for BmcMgmtToRRouter (#2136)
23e9398 [scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)
576c9ef [scripts/fast-reboot] stop timers in advance (#2131)
4dad79c bugfix: incorrect command for portchannel creation (#2134)
c17b1f4 [show][muxcable] Decrease the timeout for show mux status/hwmode (#2130)
49d61f8 [scripts/fast-reboot] cleanup (#2132)
52ca324 [config/config_mgmt.py]: Fix dpb issue with upper case mac in (#2066)
9e2fbf4 Update db_migrator to support `pfcwd_sw_enable` (#2087)
4010bd0 FGNHG CLI changes (#1588)
6bd54d0 Fix 'show mac' output when FDB entry for default vlan is None instead of 1 (#2126)
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6148955: Manual merge internal branch with github master br…
a1e7352 
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
vadymhlushko-mlnx pushed a commit to vadymhlushko-mlnx/sonic-buildimage that referenced this pull request Nov 11, 2022
@stepanblyschak
[techsupport] improve robustness (sonic-net#2117)
29771e7 
- What I did
Execute the command in a separate bash process under timeout. Due to with '--foreground' the child processes are not killed and still have the file descriptor opened to piped process which will basically hang forever.
From the "timeout" man page:
       --foreground

              when not running timeout directly from a shell prompt,

              allow COMMAND to read from the TTY and get TTY signals; in
              this mode, children of COMMAND will not be timed out
So, a command like this:

timeout --foreground 5s some_process_that_spawn_childs_that_produce_output | tee some_file
Will actually hang forever. The '--foreground' option is still needed. So the proposed solution is to run that construct in another bash process:

timeout --foreground 5s bash -c "some_process_that_spawn_childs_that_produce_output | tee some_file"
Moved hw-mgmt-dump to collect_mellanox function and execute it under timeout.
Handle global timeout: When global timeout is reached the SIGTERM is sent to generate_dump process, upon SIGTERM the generate_dump process will finalize its work by creating a dump of what already has been collected, providing a dump even when timeout is reached. The generate_dump will be killed in case it cannot create dump after initial SIGTERM.

- How I did it
I implemented the above mentioned features.

- How to verify it
Artificially hang the FW, execute "show techsupport" and verify even in case timeout is reached the dump is generated.

Signed-off-by: Stepan Blyschak <[email protected]>
vadymhlushko-mlnx pushed a commit to vadymhlushko-mlnx/sonic-buildimage that referenced this pull request Nov 11, 2022
@stepanblyschak
[show] fix get routing stack routine (sonic-net#2137)
22a388b 
- What I did
Fixed error message: "Failed to get routing stack: a bytes-like object is required, not 'str'" introduced by sonic-net#2117

- How I did it
Add missing 'text' parameter

- How to verify it
Run on switch

Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Bug 🐛 Platform: DellEMC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paavaanan @lguohan @jleveque @padmanarayana @stcheng