You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133)
The current implementation has two issues:
1. In case containers from "docker ps" output are ordered in a way that database is first in the list, the "systemctl stop database" followed by "docker kill database" will stop all other containers through systemd
and ruin this optimization
2. After "docker kill database" there are lots of errors from daemons like hostcfgd, system-healthd, caclmgrd, etc. Also it causes those daemons to hang when received SIGTERM making a delay on following "systemctl stop database".
In the new implementation, services are implicitly stopped by systemd in the order that is correct. If a certain container needs an optimization that will kill the container instead of stopping it the container may implement this optimization in its /usr/local/bin/*.sh script.
It is also more optimal since independent services might be stopped in parallel.
- What I did
Stop services using systemd
- How I did it
Stop services using systemd
- How to verify it
Run warm-reboot.
Signed-off-by: Stepan Blyschak <[email protected]>
0 commit comments