Fix QoS configuations for Quicksilver #19315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config
lguohan
reviewed
Jun 15, 2024
| "egress_lossless_pool": { | ||
| "size": "41300000", |
There was a problem hiding this comment.
in the sai definition, we do not have ITM concept. we treat whole device as pool, and therefore i am not sure we need to cut this in half is satisfying the sai definition.
There was a problem hiding this comment.
I think you're right, but these are just placeholder values to fix a SAI crash anyways. We'll be updating these with tuned values shortly.
|
hi @rick-arista , thanks a lot for sending this PR - somehow with this fix, the PFC frame still cannot be sent out with ixia test. I can see the new pg profile is created now and the ports are associated with it, but no PFC frame will be generated:
|
Add additional fixes for PFC
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 25, 2024
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config Why I did it This change is needed to fix a SAI crash on boot. These values zero out the reserved buffer space that by default would cause the pools defined in config_db.json to fail to create due to insufficient remaining room. How I did it The buffer pool values were chosen by simply dividing the total available MMU memory into 3 pools. How to verify it Without this change device fails to boot correctly.
|
Cherry-pick PR to 202311: #19393 |
yxieca
pushed a commit
that referenced
this pull request
Jun 26, 2024
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config Why I did it This change is needed to fix a SAI crash on boot. These values zero out the reserved buffer space that by default would cause the pools defined in config_db.json to fail to create due to insufficient remaining room. How I did it The buffer pool values were chosen by simply dividing the total available MMU memory into 3 pools. How to verify it Without this change device fails to boot correctly. Co-authored-by: rick-arista <[email protected]>
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config Why I did it This change is needed to fix a SAI crash on boot. These values zero out the reserved buffer space that by default would cause the pools defined in config_db.json to fail to create due to insufficient remaining room. How I did it The buffer pool values were chosen by simply dividing the total available MMU memory into 3 pools. How to verify it Without this change device fails to boot correctly.
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config Why I did it This change is needed to fix a SAI crash on boot. These values zero out the reserved buffer space that by default would cause the pools defined in config_db.json to fail to create due to insufficient remaining room. How I did it The buffer pool values were chosen by simply dividing the total available MMU memory into 3 pools. How to verify it Without this change device fails to boot correctly.
|
@rick-arista Please file another PR for 202405 branch to address cherry-pick conflict. |
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config Why I did it This change is needed to fix a SAI crash on boot. These values zero out the reserved buffer space that by default would cause the pools defined in config_db.json to fail to create due to insufficient remaining room. How I did it The buffer pool values were chosen by simply dividing the total available MMU memory into 3 pools. How to verify it Without this change device fails to boot correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds egress_lossy_pool and fixes SAI error caused by TH5 default config
Why I did it
This change is needed to fix a SAI crash on boot. These values zero out the reserved buffer space that by default would cause the pools defined in config_db.json to fail to create due to insufficient remaining room.
Work item tracking
How I did it
The buffer pool values were chosen by simply dividing the total available MMU memory into 3 pools.
How to verify it
Without this change device fails to boot correctly.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix QoS configuations for Quicksilver