-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove the divide by 4 operation to the under the hood SAI #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is to avoid the need and thus the confusion for application program to know the mmu internal architecture This change must have support from SAI change to reach the correct config Signed-off-by: Wenda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wenda,
You need to change 7260, 7060, and 6100 at the same time. Basically, any TH, TH2 platform with buffer configuration needs to be updated. And you also need to wait until the sai update is in place before merging it.
retest this please |
lossless pool Extend to 7060 and 6100 Signed-off-by: Wenda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me merge it.
I need to get SAI upgraded first.
Thanks,
Ying
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
- Broadcom SAI 3.5 GA release 20190924. Signed-off-by: Ying Xie <[email protected]>
retest this please |
* Remove the divide by 4 operation to the under the hood SAI This is to avoid the need and thus the confusion for application program to know the mmu internal architecture This change must have support from SAI change to reach the correct config Signed-off-by: Wenda <[email protected]> * Relegate the divide by 4 operation to the under the hood SAI for egress lossless pool Extend to 7060 and 6100 Signed-off-by: Wenda <[email protected]> * Add more TH/TH2 hwskus Signed-off-by: Wenda Ni <[email protected]> * Update config test Signed-off-by: Wenda Ni <[email protected]> * Add TH2 ingress lossy profile Signed-off-by: Wenda Ni <[email protected]> * Move the divide by 4 operation to SAI internal Signed-off-by: Wenda Ni <[email protected]> * [bcm SAI] Upgrade Broadcom SAI to version 3.5.3.1-15 - Broadcom SAI 3.5 GA release 20190924. Signed-off-by: Ying Xie <[email protected]>
Including folowing changes: - [portsorch] adjust port initialized event back to notice (sonic-net#1532) Signed-off-by: Ying Xie <[email protected]>
- Why I did it Advance swss submodule to pick up latest changes. - How I did it Including folowing changes: [portsorch] adjust port initialized event back to notice (#1532) Signed-off-by: Ying Xie [email protected]
) Signed-off-by: Ying Xie <[email protected]>
…tically (#21773) #### Why I did it src/sonic-sairedis ``` * ec8b3c30 - (HEAD -> 202411, origin/202411) Fix pipeline errors related to rsyslogd and libswsscommon installation (#1535) (16 hours ago) [mssonicbld] * 6b263b8e - [FC] Support Policer Counter (#1533) (28 hours ago) [mssonicbld] * e53489e5 - [syncd] Update log level for bulk api (#1532) (33 hours ago) [Jianyue Wu] ``` #### How I did it #### How to verify it #### Description for the changelog
…D automatically (sonic-net#1016) #### Why I did it src/sonic-sairedis ``` * 86d1413 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #45 from r12f/code-sync-202412 (31 minutes ago) [Riff] * 0fcc968 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (13 hours ago) [r12f] * 4048483 - Revert "Optimize counter polling interval by making it more accurate (sonic-net#1457) …" (sonic-net#1570) (2 weeks ago) [Kumaresh Perumal] * 420d92f - Update build_and_install_module.sh to match newer Linux kernel version (sonic-net#1561) (4 weeks ago) [mssonicbld] * e2d2ca6 - [vslib] SAI_KEY_VS_OPER_SPEED_IS_CONFIGURED_SPEED, SAI_PORT_ATTR_HOST_TX_READY_STATUS support (sonic-net#1553) (5 weeks ago) [mssonicbld] * 8c17d4b - Revert "Do not enter vendor SAI critical section for counter polling/clearing operations (sonic-net#1450)" (sonic-net#1541) (7 weeks ago) [mssonicbld] * 3df03e1 - Optimize counter polling interval by making it more accurate (sonic-net#1457) (sonic-net#1534) (7 weeks ago) [Stephen Sun] * d884ff9 - [syncd] Move logSet logGet under mutex to prevent race condition (sonic-net#1520) (sonic-net#1538) (8 weeks ago) [Kamil Cudnik] * ec8b3c3 - Fix pipeline errors related to rsyslogd and libswsscommon installation (sonic-net#1535) (8 weeks ago) [mssonicbld] * 6b263b8 - [FC] Support Policer Counter (sonic-net#1533) (8 weeks ago) [mssonicbld] * e53489e - [syncd] Update log level for bulk api (sonic-net#1532) (8 weeks ago) [Jianyue Wu] * 7ae00e5 - Define bulk chunk size and bulk chunk size per counter ID (sonic-net#1528) (9 weeks ago) [mssonicbld] * f35e743 - [nvidia] Skip SAI discovery on ports (sonic-net#1524) (2 months ago) [mssonicbld] * bf049ed - Use sonictest pool instead of sonic-common and fix arm64 issue. (sonic-net#1516) (2 months ago) [mssonicbld] * ffe371d - [syncd] Support bulk set in INIT_VIEW mode (sonic-net#1517) (2 months ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture
This change must have support from SAI change to reach the correct
config
Signed-off-by: Wenda [email protected]
- What I did
Delegate the divide-by-4 operation in setting the static threshold of egress queue for lossless traffic to the underneath SAI.
- How I did it
Change the buffers config json.
- How to verify it
Change the config_db.json on a7260 and dump the config after the change for verification.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)