-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[LLDP] lldp portidsubtype was NOT set to "locally assigned" but "mac address" #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am unable to reproduce this problem on two different devices, both also configured for a T0 test topology, and both running a build from last night. Below is my output from two peer Arista VMs of one of the devices. Note that the portidsubtype is correctly set to "Locally assigned" and both Port ID and Port Description are also configured correctly. Could you please provide all log messages from lldpmgrd so that I can determine whether or not it is behaving correctly for you?
|
@jleveque I tried on 4 devices with t0 and t1 and t1-lag topo, all of them still have this issue with the image built on 5th Mar.
check on Arista VM
I filtered out the lldpmgr log as below
|
@jleveque btw, if I run the command "lldpcli configure ports Ethernet120 lldp portidsubtype local Ethernet120 description ARISTA04T1:Ethernet1" explicitly, from the Arista VM can see that the port id and port description changed as expected:
|
@keboliu: I was able to reproduce the issue. It appears to be caused by a race condition when the interfaces are initially created. We are still investigating the root cause, but if you wouldn't mind, could you please test the following workaround to confirm whether this also resolves the issue on your devices? Add a
|
@jleveque good to know it can be reproduced, I can test it, will update you when having the result. |
@jleveque the workaround doesn't work on my testbed, still have the same issue. |
@keboliu: I forgot to mention you would also need to add the line |
@jleveque I sent out the tetst log with Guohan's lldpcli patch. do you still need to test this workaround? |
@keboliu: If you have time, please do. It would help confirm the race condition we found. |
…D automatically (sonic-net#1016) #### Why I did it src/sonic-sairedis ``` * 86d1413 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #45 from r12f/code-sync-202412 (31 minutes ago) [Riff] * 0fcc968 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (13 hours ago) [r12f] * 4048483 - Revert "Optimize counter polling interval by making it more accurate (sonic-net#1457) …" (sonic-net#1570) (2 weeks ago) [Kumaresh Perumal] * 420d92f - Update build_and_install_module.sh to match newer Linux kernel version (sonic-net#1561) (4 weeks ago) [mssonicbld] * e2d2ca6 - [vslib] SAI_KEY_VS_OPER_SPEED_IS_CONFIGURED_SPEED, SAI_PORT_ATTR_HOST_TX_READY_STATUS support (sonic-net#1553) (5 weeks ago) [mssonicbld] * 8c17d4b - Revert "Do not enter vendor SAI critical section for counter polling/clearing operations (sonic-net#1450)" (sonic-net#1541) (7 weeks ago) [mssonicbld] * 3df03e1 - Optimize counter polling interval by making it more accurate (sonic-net#1457) (sonic-net#1534) (7 weeks ago) [Stephen Sun] * d884ff9 - [syncd] Move logSet logGet under mutex to prevent race condition (sonic-net#1520) (sonic-net#1538) (8 weeks ago) [Kamil Cudnik] * ec8b3c3 - Fix pipeline errors related to rsyslogd and libswsscommon installation (sonic-net#1535) (8 weeks ago) [mssonicbld] * 6b263b8 - [FC] Support Policer Counter (sonic-net#1533) (8 weeks ago) [mssonicbld] * e53489e - [syncd] Update log level for bulk api (sonic-net#1532) (8 weeks ago) [Jianyue Wu] * 7ae00e5 - Define bulk chunk size and bulk chunk size per counter ID (sonic-net#1528) (9 weeks ago) [mssonicbld] * f35e743 - [nvidia] Skip SAI discovery on ports (sonic-net#1524) (2 months ago) [mssonicbld] * bf049ed - Use sonictest pool instead of sonic-common and fix arm64 issue. (sonic-net#1516) (2 months ago) [mssonicbld] * ffe371d - [syncd] Support bulk set in INIT_VIEW mode (sonic-net#1517) (2 months ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
In the latest version
the lldp portidsubtype wasn't set to "locally assigned" but "mac address", it can be verified on the peer Arista VM with t0 topology.
This is different with the version build on 28th Feb, on this version it was set to "locally assigned"
when this happened, the lldpmgrd is running:
The text was updated successfully, but these errors were encountered: