Fix flaky specs #6197
Merged
Fix flaky specs #6197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
mamhoff
force-pushed
the
fix-flaky-specs
branch
2 times, most recently
from
5e87b17 to
6694683
Compare
The "spec_helper" does not include all the features necessary for feature specs.
We can't be sure the action has been created without having had confirmation on the screen.
We need to make sure that the browser has updated the page contents before checking for the updated path.
Otherwise, `Spree::Image.first` might not have its attachment yet.
Otherwise, the current path might not be what we expect yet.
Otherwise, the benefit might not have updated in the database yet.
We can just test that the buttons have the necessary attribute for the behaviour. These tests had become flaky.
mamhoff
force-pushed
the
fix-flaky-specs
branch
from
6694683 to
52791fe
Compare
This should help fix some really ugly flaky test runs. See teamcapybara/capybara#2800 for context.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6197 +/- ##
==========================================
+ Coverage 85.72% 88.81% +3.09%
==========================================
Files 444 836 +392
Lines 10087 18164 +8077
==========================================
+ Hits 8647 16133 +7486
- Misses 1440 2031 +591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
re-ran specs. just out of curiosity |
tvdeyen
added
backport-v4.4
Merged
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're experiencing another wave of flaky specs, most likely because chrome or Selenium have become faster. These changes make our test suite wait in appropriate places and stop testing Rails behaviour that we don't need to test.
Checklist
The following are not always needed: