Do not test Rails disable-with behavior

We can just test that the buttons have the necessary attribute for the
behaviour.

These tests had become flaky.

Author: mamhoff

backend/spec/features/admin/orders/customer_returns_spec.rb

@@ -33,25 +33,14 @@ def expect_order_state_label_to_eq(text)
       end
     end
 
-    it 'disables the button at submit', :js do
-      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-
-      create_customer_return('receive')
-
-      expect(page).to have_button("Create", disabled: true)
+    it 'disables the button at submit' do
+      expect(page).to have_css('input[type="submit"][data-disable-with="Create"]')
     end
 
     context 'when creating a return with state "In Transit" and then marking it as "Received"' do
       it 'disables the "Receive" button at submit', :js do
         create_customer_return('in_transit')
-
-        page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-
-        within('[data-hook="rejected_return_items"] tbody tr:nth-child(1)') do
-          click_button('Receive')
-
-          expect(page).to have_button("Receive", disabled: true, wait: 5)
-        end
+        expect(page).to have_css('input[type="submit"][data-disable-with="Receive"]')
       end
 
       it 'marks the order as returned', :js do

backend/spec/features/admin/orders/return_payment_state_spec.rb

@@ -67,14 +67,9 @@ def create_customer_return
     )
   end
 
-  it 'disables the "Create Reimbursement" button at submit', :js do
+  it 'disables the "Create Reimbursement" button at submit' do
     create_customer_return
 
-    page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-
-    # Create reimbursement
-    click_on 'Create reimbursement'
-
-    expect(page).to have_button("Create reimbursement", disabled: true)
+    expect(page).to have_css("input[type='submit'][data-disable-with='Create reimbursement']")
   end
 end

legacy_promotions/spec/features/backend/promotion_adjustments_spec.rb

@@ -167,13 +167,8 @@
       expect(promotion.actions.first).to be_a(Spree::Promotion::Actions::FreeShipping)
     end
 
-    it "disables the button at submit", :js do
-      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-      fill_in "Name", with: "SAVE SAVE SAVE"
-      choose "Apply to all orders"
-      click_button "Create"
-
-      expect(page).to have_button("Create", disabled: true)
+    it "disables the button at submit" do
+      expect(page).to have_css("input[type='submit'][data-disable-with='Create']")
     end
 
     it "should allow an admin to create an automatic promotion" do

legacy_promotions/spec/features/backend/promotions/promotion_code_batches_spec.rb

@@ -23,18 +23,14 @@ def create_code_batch
       expect(page).to_not have_field("promotion_per_code_usage_limit")
     end
 
-    it "creates a new promotion code batch and disables the submit button", :js do
+    it "creates a new promotion code batch and disables the submit button" do
       create_code_batch
 
       expect(page).to have_content "Promotion Code Batch has been successfully created!"
 
       visit spree.new_admin_promotion_promotion_code_batch_path(promotion)
 
-      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-
-      create_code_batch
-
-      expect(page).to have_button("Create", disabled: true)
+      expect(page).to have_css("input[type='submit'][data-disable-with='Create']")
     end
   end
 end

legacy_promotions/spec/features/backend/promotions/promotion_code_spec.rb

@@ -19,13 +19,8 @@
       expect(page).to have_content "Promotion Code has been successfully created!"
     end
 
-    it "disables the button at submit", :js do
-      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-
-      fill_in "Value", with: "XYZ"
-      click_button "Create"
-
-      expect(page).to have_button("Create", disabled: true)
+    it "disables the button at submit" do
+      expect(page).to have_css("input[type='submit'][data-disable-with='Create']")
     end
   end
 end