fix: Improve animated ref value type #8052
Open
+159
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
commented
Aug 11, 2025
| @@ -27,7 +27,7 @@ export default function GetViewPropExample() { | |||
| const handlePress = async () => { | |||
| // @ts-ignore this is fine | |||
| const viewTag = animatedRef() as number; | |||
| const result = await getViewProp(viewTag, 'opacity'); | |||
| const result = await getViewProp(viewTag, 'opacity', animatedRef.current); | |||
MatiPl01
commented
Aug 11, 2025
| __internalInstanceHandle?: AnyRecord; | ||
| }; | ||
|
|
||
| export type WrapperRef = (React.Component & InstanceMethods) | InstanceMethods; |
There was a problem hiding this comment.
We can't use just the InstanceMethods type as the useAnimatedRef by default returns a reference to the React.Component type, which has no methods in common with the InstanceMethods type. useAnimatedRef must return the Component type by default in order to make the ref assignable to any React Native's built-in component without requiring the specification of the template type:
const ref = useAnimatedRef(); // don't have to write: useAnimatedRef<View>()
<View ref={ref} />
MatiPl01
commented
Aug 11, 2025
| getInternalInstanceHandleFromPublicInstance = (_ref: any) => | ||
| _ref._internalInstanceHandle; | ||
| } | ||
| } | ||
|
|
||
| // TODO: Clean this up since 0.74 is the minimum supported version now. |
There was a problem hiding this comment.
Not sure if I should somehow address this TODO. I just refactored this code to the more concise and simpler implementation but didn't remove any logic which may be no longer necessary in latest versions of RN.
MatiPl01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves types used for the animated ref value. The previous implementation required the value to be an instance of the
React.Component, which worked in most cases. This broke inFlashListv2 because therefprop doesn't extend theReact.Componenttype and instead it included just types of a few methods that can be used to obtain the view instance.