Remove isFabric(), viewName, getScrollableNode along with all usages
#7103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejbloniarz
approved these changes
Feb 26, 2025
tjzel
approved these changes
Feb 26, 2025
apps/common-app/src/apps/reanimated/examples/RuntimeTests/ReJest/TestRunner/UpdatesContainer.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-with: Krzysztof Piaskowy [email protected]
Summary
This PR replaces all
isFabric(),IS_FABRICandglobal._IS_FABRICchecks withtrue(as well as optimizes the expressions and removes dead code).Turns out,
getScrollableNodecall was inside!IS_FABRICso we also removed that.We also removed
viewNamefromViewDescriptoras it was used only on Paper.Test plan