Backport changes to 3.17 #7041
Merged
Backport changes to 3.17 #7041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After switching to new `findNodeHandle` implementation based on `display: contents;`, we can no longer detect components from `SVG` that are wrapped using `createAnimatedComponent` (see [issue](software-mansion/react-native-gesture-handler#3356) on Gesture Handler side). This is because our [Wrap](https://github.com/software-mansion/react-native-gesture-handler/blob/7f90209add0b761d3738882339f4949b31f6f88f/src/handlers/gestures/GestureDetector/Wrap.web.tsx#L9) receives `forwardRef` as child - that makes it impossible to detect what component is used inside. Theoretically we could do something like ```js child.type.render().displayName ``` and use regex to get component name, but it would be very expensive. Instead, we can add `displayName` directly to `forwardRef` on Reanimated side. This should help us detect if component passed inside `createAnimatedComponent` was from `SVG`. Code used inside our [Wrap.web.tsx](https://github.com/software-mansion/react-native-gesture-handler/blob/7f90209add0b761d3738882339f4949b31f6f88f/src/handlers/gestures/GestureDetector/Wrap.web.tsx#L9) ```jsx const child = React.Children.only(children); console.log(child) console.log(child.type.displayName) ``` gives the following result: <img width="605" alt="image" src="https://github.com/user-attachments/assets/e12059bb-ebbc-4812-8a1a-ae8eb6507cf2" />
Starting from Android 15 devices can use 16KB page size instead of 4KB. Apps that take advantage of this require additional linker flag. This PR adds aforementioned flag so that apps that use Reanimated don't crash. >[!NOTE] > More info can be found [here](https://developer.android.com/guide/practices/page-sizes) Tested on fabric-example on AVD with 16KB page size.
tjzel
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains cherry-picked commits that should be backported to 3.17
displayNametoforwardReffromAnimatedComponent#6978Test plan