-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Android] Add support for 16KB page size #7037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Feb 17, 2025
tjzel
approved these changes
Feb 17, 2025
kkafar
pushed a commit
to software-mansion/react-native-screens
that referenced
this pull request
Feb 18, 2025
## Description Starting from Android 15 devices can use 16KB page size instead of 4KB. Apps that take advantage of this require additional linker flag. This PR adds aforementioned flag so that apps that use Screens don't crash. >[!NOTE] > More info can be found [here](https://developer.android.com/guide/practices/page-sizes) ## Test plan I've tested it while working on the same change in [Reanimated](software-mansion/react-native-reanimated#7037). After adding this flag into screens app stopped crashing. I've also tested it on `FabricExample` in Screens on AVD with 16KB page size. I've had some problems with this example app, but after adding this flag it stopped crashing on start (it still show some errors about undefined function though, but I believe the problem lies in my setup).
m-bert
added a commit
that referenced
this pull request
Feb 18, 2025
Starting from Android 15 devices can use 16KB page size instead of 4KB. Apps that take advantage of this require additional linker flag. This PR adds aforementioned flag so that apps that use Reanimated don't crash. >[!NOTE] > More info can be found [here](https://developer.android.com/guide/practices/page-sizes) Tested on fabric-example on AVD with 16KB page size.
tjzel
pushed a commit
that referenced
this pull request
Feb 18, 2025
Starting from Android 15 devices can use 16KB page size instead of 4KB. Apps that take advantage of this require additional linker flag. This PR adds aforementioned flag so that apps that use Reanimated don't crash. >[!NOTE] > More info can be found [here](https://developer.android.com/guide/practices/page-sizes) Tested on fabric-example on AVD with 16KB page size.
antonis
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
Mar 5, 2025
10 tasks
antonis
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
Mar 5, 2025
…pp (#4623) * Update react-native-screens and react-native-gesture-handler to support 16KB - https://github.com/software-mansion/react-native-screens/releases/tag/4.8.0 - https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.24.0 * Bumps react-native-reanimated to 3.17.1 that supports 16KB with software-mansion/react-native-reanimated#7037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting from Android 15 devices can use 16KB page size instead of 4KB. Apps that take advantage of this require additional linker flag.
This PR adds aforementioned flag so that apps that use Reanimated don't crash.
Note
More info can be found here
Test plan
Tested on fabric-example on AVD with 16KB page size.