Skip to content

[Android] Add support for 16KB page size #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Feb 17, 2025

Description

Starting from Android 15 devices can use 16KB page size instead of 4KB. Apps that take advantage of this require additional linker flag.

This PR adds aforementioned flag so that apps that use Reanimated don't crash.

Note

More info can be found here

Test plan

Tested on fabric-example on AVD with 16KB page size.

@m-bert m-bert requested review from tjzel, tomekzaw and piaskowyk and removed request for tjzel February 17, 2025 14:13
@m-bert m-bert added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit ac80a47 Feb 18, 2025
18 checks passed
@m-bert m-bert deleted the @mbert/support-16kb-page-size branch February 18, 2025 08:42
kkafar pushed a commit to software-mansion/react-native-screens that referenced this pull request Feb 18, 2025
## Description

Starting from Android 15 devices can use 16KB page size instead of 4KB.
Apps that take advantage of this require additional linker flag.

This PR adds aforementioned flag so that apps that use Screens don't
crash.

>[!NOTE]
> More info can be found
[here](https://developer.android.com/guide/practices/page-sizes)

## Test plan

I've tested it while working on the same change in
[Reanimated](software-mansion/react-native-reanimated#7037).
After adding this flag into screens app stopped crashing.


I've also tested it on `FabricExample` in Screens on AVD with 16KB page
size. I've had some problems with this example app, but after adding
this flag it stopped crashing on start (it still show some errors about
undefined function though, but I believe the problem lies in my setup).
m-bert added a commit that referenced this pull request Feb 18, 2025
Starting from Android 15 devices can use 16KB page size instead of 4KB.
Apps that take advantage of this require additional linker flag.

This PR adds aforementioned flag so that apps that use Reanimated don't
crash.

>[!NOTE]
> More info can be found
[here](https://developer.android.com/guide/practices/page-sizes)

Tested on fabric-example on AVD with 16KB page size.
@m-bert m-bert mentioned this pull request Feb 18, 2025
tjzel pushed a commit that referenced this pull request Feb 18, 2025
Starting from Android 15 devices can use 16KB page size instead of 4KB.
Apps that take advantage of this require additional linker flag.

This PR adds aforementioned flag so that apps that use Reanimated don't
crash.

>[!NOTE]
> More info can be found
[here](https://developer.android.com/guide/practices/page-sizes)

Tested on fabric-example on AVD with 16KB page size.
antonis added a commit to getsentry/sentry-react-native that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants