Skip to content

fix: GitHub deprecation warnings #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pau1ocampos
Copy link

Closes #43

Context

GitHub will deprecate set-output command and node12 as of 31st May 2023.
@actions/core should be upgraded for v1.10.0.
action.yml file should run on node16.
Please refer to this documentation.

Description

This pull request intends to upgrade @actions/core to v1.10.0 and update action.yml file to contemplate nodejs16 instead of nodejs12 so that this action can be compliant with new GitHub requirements.

@pau1ocampos pau1ocampos force-pushed the fix/github-deprecations branch from e6ffa68 to 17e7c2e Compare November 6, 2022 00:09
@michaelstepner
Copy link

FYI, Github has incorporated equivalent functionality to turnstyle into the Github Actions spec using the 'concurrency' parameter. softprops/turnstyle was developed in 2020 and Github added the concurrency parameter in 2021.

The native 'concurrency' implementation has additional features beyond what's possible in turnstyle, and it is lower cost: it leaves jobs pending rather than running while they wait for a previous job to end.

@pau1ocampos pau1ocampos closed this Dec 8, 2022
@pau1ocampos pau1ocampos deleted the fix/github-deprecations branch December 8, 2022 10:41
@jeherve
Copy link

jeherve commented Feb 1, 2023

While the concurrency parameter is useful, I'm afraid there are still situations1 where it isn't enough to catch potential duplicated runs. In those situations, softprops/turnstyle can still be useful.

I would consequently recommend reopening this PR, it can still be useful in avoiding deprecation warnings for those still having to rely on softprops/turnstyle

Thanks!

Footnotes

  1. For reference, here is one such case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 12 deprecated
4 participants