Node 12 deprecated

[hkroger]

Should this be updated to use node 16 as github is suggesting?

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

[fbuinosquy1985]

Please merge it.

[michaelstepner]

FYI, Github has incorporated equivalent functionality to turnstyle into the Github Actions spec using the 'concurrency' parameter. softprops/turnstyle was developed in 2020 and Github added the concurrency parameter in 2021.

The native 'concurrency' implementation has additional features beyond what's possible in turnstyle, and it is lower cost: it leaves jobs pending rather than running while they wait for a previous job to end.

[jeherve]

I commented on the atttached PR but wanted to post this here as well for extra visibility.

While the concurrency parameter is useful, I'm afraid there are still situations¹ where it isn't enough to catch potential duplicated runs. In those situations, softprops/turnstyle can still be useful.

Thanks!

Footnotes

1. For reference, here is one such case. ↩

[anomiex]

More generally, GitHub's concurrency parameter handles the cases where you want existing runs (queued and optional the in-progress run too) to be cancelled when a new run comes in, but does not (yet) handle cases where you want runs to wait for in-progress runs without any being cancelled.

See https://github.com/orgs/community/discussions/5435 for one discussion asking for the feature (with GH replying "we hope to get to this someday").

[daimenworrall-cinch]

Hello! Are there any updates on this issue? Thanks!

[chenrui333]

Close as fixed. Thanks!