Skip to content

feat: ✨ add project level manual scan [ROAD-1239] #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 3, 2023
Merged

feat: ✨ add project level manual scan [ROAD-1239] #203

merged 13 commits into from
Jan 3, 2023

Conversation

bastiandoetsch
Copy link
Collaborator

@bastiandoetsch bastiandoetsch commented Dec 23, 2022 •
edited
Loading

Description

This PR adds a command to scan a workspace folder.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner December 23, 2022 07:29
@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 23, 2022 07:29 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 23, 2022 07:29 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 23, 2022 07:29 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 23, 2022 07:29 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 23, 2022 07:40 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 23, 2022 07:40 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 23, 2022 07:40 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 23, 2022 07:40 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 23, 2022 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 23, 2022 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 23, 2022 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 23, 2022 07:46 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 23, 2022 07:50 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 23, 2022 07:50 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 23, 2022 07:50 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 23, 2022 07:50 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 23, 2022 09:23 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 23, 2022 09:23 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 23, 2022 09:23 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 23, 2022 09:23 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 23, 2022 09:50 — with GitHub Actions Inactive
This was referenced Dec 23, 2022
Merged
Merged
asaf92
asaf92 reviewed Dec 25, 2022
View reviewed changes
asaf92
asaf92 reviewed Dec 25, 2022
View reviewed changes
@asaf92 asaf92 temporarily deployed to Standard December 25, 2022 09:48 — with GitHub Actions Inactive
@asaf92 asaf92 temporarily deployed to MT1 December 25, 2022 09:48 — with GitHub Actions Inactive
@asaf92 asaf92 temporarily deployed to MT2 December 25, 2022 09:48 — with GitHub Actions Inactive
@asaf92 asaf92 temporarily deployed to MT3 December 25, 2022 09:48 — with GitHub Actions Inactive
asaf92
asaf92 suggested changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@asaf92 asaf92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trimming the suffix leads to wrong results in FolderContains, check the test I added

@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 29, 2022 07:44 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 29, 2022 07:44 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 29, 2022 07:44 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 29, 2022 07:44 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to Standard December 29, 2022 08:11 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 December 29, 2022 08:11 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 December 29, 2022 08:11 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 December 29, 2022 08:11 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to Standard January 3, 2023 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT1 January 3, 2023 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT2 January 3, 2023 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch temporarily deployed to MT3 January 3, 2023 07:45 — with GitHub Actions Inactive
@bastiandoetsch bastiandoetsch merged commit 1e6a194 into main Jan 3, 2023
@bastiandoetsch bastiandoetsch deleted the feat/road-1239_add_project_level_manual_scan branch January 3, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaf92 asaf92 asaf92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastiandoetsch @asaf92