feat: add project scan capability, preserve workspace scan function [ROAD-1239] #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaf92
suggested changes
Jan 3, 2023
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Show resolved
Hide resolved
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Show resolved
Hide resolved
bastiandoetsch
force-pushed
the
feat/ROAD-1239_add_project_scan_capability
branch
from
932ab2c to
89299ed
Compare
asaf92
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the Snyk Test action in the context menu triggered a workspace scan. This had some unwanted side-effects for customers:
Now, Snyk Test only scans the selected project, and a new menu item is added for workspace scan (see screenshot)
Must be merged/released AFTER snyk/snyk-ls#203
Checklist
Screenshots / GIFs