fix: SnykCode root nodes update after scan finished [ROAD-439] #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldanchenko
reviewed
Oct 17, 2021
| addHMLPostfix = securityIssuesHMLPostfix | ||
| ) | ||
| } | ||
| updateTreeRootNodesPresentation( |
There was a problem hiding this comment.
Could you share why ApplicationManager.getApplication().invokeLater removed?
There was a problem hiding this comment.
We are already inside EDT (fun caller is under invokeLater) so no real need to wrap it here again.
It was putted there by wrong assumption and later left as workaround to create artificial delay to let "right" thread win in race condition. :)
aldanchenko
approved these changes
Oct 19, 2021
|
@aldanchenko , it will fail unless |
|
@pavel-snyk thanks for clarification! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Could (and should) be reviewed/merged only after snyk/code-sdk-java#26