This repository was archived by the owner on Feb 1, 2023. It is now read-only.
fix: isFullRescanRequested() should be False after rescan finished and before UI updates [ROAD-439] #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d before UI updates; chore: mocks skeleton for .core tests created.
aldanchenko
reviewed
Oct 17, 2021
|
|
||
| import java.util.Collection; | ||
|
|
||
| public class AnalysisDataBaseMock extends AnalysisDataBase { |
There was a problem hiding this comment.
Maybe where is some reason, but why not use some mock library?
There was a problem hiding this comment.
I feel there are too many thing to mock there as far as all that abstract classes are cross linked internally a lot.
Looks like it's easier to create "mock" versions of all needed abstract classes and run test against them
But your approach might be working too, may be I just have not enough experience with using Mockito.
There was a problem hiding this comment.
@ArtsiomCh I don't mind. It happens that I do so too. I think you know better 👍
ArtsiomCh
deleted the
fix/isFullRescanRequested_should_be_false_after_scan_finished
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: isFullRescanRequested() should be False after rescan finished and before UI updates;
chore: mocks skeleton for .core tests created.