feat: harden checkout #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
asraa,
ianlewis and
joshuagl
as code owners
laurentsimon
commented
Sep 6, 2022
| @@ -55,6 +56,9 @@ runs: | |||
| repository: "${{ inputs.repository }}" | |||
| token: "${{ inputs.token }}" | |||
|
|
|||
| - name: Verify checkout | |||
| uses: slsa-framework/slsa-github-generator/.github/actions/verify-checkout@main | |||
There was a problem hiding this comment.
Once this is merged, I will update this code to a hash pin instead of "@main"
joshuagl
approved these changes
Sep 6, 2022
|
@naveensrinivasan any idea why the |
That's my fault. That check was failing but #646 got auto-merged because the check isn't a required check on the protected branch. The fix is tracked on #793 |
|
no problem. I understand. ncc got updated and that's why it failed. Thanks |
|
I added the check-dist as a required check so auto-submits won't work if it fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #626 (comment)