[bug] check-dist pre-submit is not a required pre-submit #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ianlewis opened this issue Sep 6, 2022 · 1 comment

Assignees

Labels

area:tooling type:bug

Member

ianlewis commented Sep 6, 2022

The pre-submit actions workflow is not a required pre-submit check for merging PRs.

We need to add a job step that always runs and mark it as required for the protected branch rule.

ianlewis added type:bug area:tooling labels

ianlewis mentioned this issue

feat: harden checkout #795

Merged

ianlewis self-assigned this

Member Author

ianlewis commented Sep 7, 2022

Added check-dist as a required check on our protected branch rule. verify no checkout in Actions was already required.

ianlewis closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment