Fix linter pre-submit

[ianlewis]

Fixes #283

Needs:

• Fix golangci-lint errors #341
• Fix yamllint errors #340
• Fix shellcheck errors #338
• Update references to reusable actions. #466

This fixes linter pre-submit issues and ensures that linters cause pre-submits to fail when there are errors.

reviewdog was abandoned for now because it seems to have issues where it returns a 0 error code even if the linter produces errors. It also uses of the Github API in a way that requires more permissions than we would like to give to PR code.

Instead, this PR runs the linters manually and has them output GitHub Actions commands to output check errors.

Pros:

• Can run in a PR from a forked repo without any special permissions
• Produces comments on PR code so it's easy to see where the violation is

Cons:

• Runs on the whole repo and will match errors in files not on the PR

For now you can check out the files tab and scroll to the bottom to see examples of what the linter violations look like.

[ianlewis]

@laurentsimon Can you give this a look when you get a chance?

[laurentsimon]

LGTM, thanks. Mabye we should follow-up on what contributors need to install on their machine do run the checks locally before sending a PR?

[ianlewis]

LGTM, thanks. Mabye we should follow-up on what contributors need to install on their machine do run the checks locally before sending a PR?

I added some docs to the README