linter pre-submits don't actually fail

[ianlewis]

The reviewdog presubmits don't actually fail even though they're set to fail on error.

Seems it's an issues with the Github actions that's been around a while? reviewdog/reviewdog#907

[ianlewis]

yeah... The exit code of reviewdog isn't used in the action.
https://github.com/reviewdog/action-yamllint/blob/master/entrypoint.sh

[ianlewis]

the shellcheck linter is ok
https://github.com/reviewdog/action-shellcheck/blob/master/script.sh

[ianlewis]

It seems like the individual actions are fine, but the reviewdog binary itself doesn't return the right exit code in the case where it doesn't write to the Github API even though there are errors. This seems to be the issue folks are encountering here: reviewdog/reviewdog#907

Without making the changes to reviewdog I think we can just run the linters ourselves manually since we just want the exit code and don't need the PR comment reporting.