BUG: Uses OrderedDict for callbacks #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I just wanted to tackle this when I saw that you already submitted a PR, good job :) It is probably good to add tests for this case as well to prevent callback ordering issues in the future. Do you want to do this in this PR as well? If not, I would write tests and push them on top of this PR. |
|
This PR has been updated to test the order of callbacks. |
|
Thank you, looks good :) |
spott
pushed a commit
to spott/skorch
that referenced
this pull request
Oct 12, 2018
* BUG: Uses OrderedDict for callbacks * TST: Adds test for callback order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330