Bug in callback order when using Python < 3.6 #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

benjamin-work opened this issue Sep 4, 2018 · 0 comments

Labels

bug

Contributor

benjamin-work commented Sep 4, 2018

The offending line is here:

https://github.com/dnouri/skorch/blob/1177be7404ece996d0e6b63982f39b65fe1811e3/skorch/net.py#L366

When dictionary order is not preserved, order of the callbacks may change.

benjamin-work added the bug label

thomasjpfan mentioned this issue

BUG: Uses OrderedDict for callbacks #331

Merged

ottonemo closed this as completed in #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment