Reap leftover zombie processes #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wolf480pl
reviewed
May 26, 2023
src/executor/Executor.cc
Outdated
| if (waitpid(-1, NULL, WNOHANG) == -1 && errno != ECHILD) { | ||
| throw SystemException( | ||
| std::string("final waitpid failed: ") + strerror(errno)); | ||
| } |
There was a problem hiding this comment.
I think this could be simplified DRY-d by using withErrnoCheck(description, ignoredErrnos, func, args...)
Like this:
withErrnoCheck("final waitpid", {ECHILD}, waitpid, -1, NULL, WNOHANG)
That'd be more consistent with other code.
Unless you find withErrnoCheck confusing, then we can merge this as is.
Wolf480pl
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33.
We don't have to use the more complex
waitid(), as the child is sure to have exited already.