Reap leftover zombie processes

otargowski · otargowski · commit affdd5081ed3 · 2023-05-26T21:27:35.000+02:00
diff --git a/src/executor/Executor.cc b/src/executor/Executor.cc
@@ -190,6 +190,11 @@ void Executor::executeParent() {
     for (auto& listener: eventListeners_) {
         listener->onPostExecute();
     }
+    // This is needed, as most earlier waits have the WNOWAIT flag.
+    if (waitpid(-1, NULL, WNOHANG) == -1 && errno != ECHILD) {
+        throw SystemException(
+                std::string("final waitpid failed: ") + strerror(errno));
+    }
 }
 
 void Executor::setupSignalHandling() {

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,11 @@ void Executor::executeParent() {`
`190`	`190`	`for (auto& listener: eventListeners_) {`
`191`	`191`	`listener->onPostExecute();`
`192`	`192`	`}`
	`193`	`+ // This is needed, as most earlier waits have the WNOWAIT flag.`
	`194`	`+ if (waitpid(-1, NULL, WNOHANG) == -1 && errno != ECHILD) {`
	`195`	`+ throw SystemException(`
	`196`	`+ std::string("final waitpid failed: ") + strerror(errno));`
	`197`	`+ }`
`193`	`198`	`}`
`194`	`199`
`195`	`200`	`void Executor::setupSignalHandling() {`