Skip to content

Add options to disable runner updates #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

kuhnroyal
Copy link
Contributor

Description

Disable automatic updates of the Github runner

Motivation and Context

Closes #107

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@kuhnroyal kuhnroyal requested a review from simonbs as a code owner February 3, 2025 23:33
@simonbs
Copy link
Contributor

simonbs commented Feb 5, 2025

Thanks for the PR! The changes look great. One thing I wonder about, though, is whether we should add some explanatory text in the UI to clarify what this setting does. Even with this enabled, new versions of the runner will still be downloaded when the VM reboots, as it always fetches the latest version at that point. I worry that "Disable runner auto-update" might be misleading.

What do you think?

@kuhnroyal
Copy link
Contributor Author

Damn, I didn't think about that...
What about a runner version configuration option? If that is set, we disable updates and always install that version?

@simonbs
Copy link
Contributor

simonbs commented Feb 5, 2025

@kuhnroyal If all you're interested in is making sure Tartelet never updates the runner, even between reboots of the virtual machine, then you should edit the virtual machine, copy in the runner archive, and extract it. This part of the shell script ensures that the runner script is only downloaded if ~/actions-runner doesn't exist.

@kuhnroyal
Copy link
Contributor Author

That's actually a good idea, will check if I can adapt my build.

@kuhnroyal
Copy link
Contributor Author

Ok, I have a preinstalled runner version and it automatically updates when the runner launches.
So I am back to the idea of this PR.
I will add a description in the UI.

@kuhnroyal kuhnroyal force-pushed the feat/disable-updates branch from 5d17c51 to 064ab5c Compare February 7, 2025 16:20
@kuhnroyal
Copy link
Contributor Author

Added a description:

Bildschirmfoto 2025-02-07 um 17 20 19

@kuhnroyal
Copy link
Contributor Author

I couldn't test the config.sh changes since I can't get Tartelet to save my PEM key, everything else is being saved...

@simonbs
Copy link
Contributor

simonbs commented Feb 13, 2025

@kuhnroyal Thanks for adding the texts.

I couldn't test the config.sh changes since I can't get Tartelet to save my PEM key, everything else is being saved...

Have you looked at the comments in #2 and #86? Both issues describe similar problems with proposed workarounds.

@kuhnroyal
Copy link
Contributor Author

kuhnroyal commented Feb 28, 2025

I got it to save my key now and was able to test everything.
Fixed the name of the flag and regenerate the L10n file with swiftgen.
This should be good to go now.

I tested and checked the script in the VM with the flag on & off.
The flag defaults to false so there is no change for existing users.

@simonbs
Copy link
Contributor

simonbs commented Mar 1, 2025

@kuhnroyal Thanks! Let's merge this!

@simonbs simonbs enabled auto-merge (squash) March 1, 2025 12:58
@simonbs simonbs merged commit 158df33 into shapehq:main Mar 1, 2025
1 check passed
@kuhnroyal kuhnroyal deleted the feat/disable-updates branch March 1, 2025 17:06
@kuhnroyal
Copy link
Contributor Author

Thanks!

@kuhnroyal
Copy link
Contributor Author

@simonbs Can you release this by any chance? Thanks!

@simonbs
Copy link
Contributor

simonbs commented Mar 10, 2025

@kuhnroyal This is now available in version 0.11.0.

@kuhnroyal
Copy link
Contributor Author

Wow, that was fast. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Github Runner auto update
2 participants