Add options to disable runner updates (#108)

* Add options to disable runner updates

* Fix typo

* Fix flag name & regenerate swiftgen

Author: kuhnroyal

.gitignore

@@ -1,5 +1,6 @@
 .DS_Store
 .build
+.index-build
 .swiftpm
 xcuserdata
 Tartelet.xcodeproj

.swiftlint.yml

@@ -4,6 +4,7 @@ excluded:
   - Packages/Settings/Sources/SettingsUI/Internal/Assets.swift
   - Packages/Settings/Sources/SettingsUI/Internal/L10n.swift
   - "**/.build"
+  - "**/.index-build"
 opt_in_rules:
   - anonymous_argument_in_multiline_closure
   - array_init

Packages/Settings/Sources/SettingsData/AppStorageSettingsStore.swift

@@ -11,6 +11,7 @@ public final class AppStorageSettingsStore: SettingsStore {
         static let numberOfVirtualMachines = "numberOfVirtualMachines"
         static let startVirtualMachinesOnLaunch = "startVirtualMachinesOnLaunch"
         static let gitHubPrivateKeyName = "gitHubPrivateKeyName"
+        static let gitHubRunnerDisableUpdates = "gitHubRunnerDisableUpdates"
         static let gitHubRunnerLabels = "gitHubRunnerLabels"
         static let gitHubRunnerGroup = "gitHubRunnerGroup"
         static let githubRunnerScope = "githubRunnerScope"
@@ -91,6 +92,17 @@ public final class AppStorageSettingsStore: SettingsStore {
             }
         }
     }
+    public var gitHubRunnerDisableUpdates: Bool {
+        get {
+            access(keyPath: \.gitHubRunnerDisableUpdates)
+            return userDefaults.bool(forKey: AppStorageKey.gitHubRunnerDisableUpdates)
+        }
+        set {
+            withMutation(keyPath: \.gitHubRunnerDisableUpdates) {
+                userDefaults.setValue(newValue, forKey: AppStorageKey.gitHubRunnerDisableUpdates)
+            }
+        }
+    }
     public var gitHubRunnerLabels: String {
         get {
             access(keyPath: \.gitHubRunnerLabels)

Packages/Settings/Sources/SettingsDomain/SettingsStore.swift

@@ -8,6 +8,7 @@ public protocol SettingsStore: AnyObject {
     var numberOfVirtualMachines: Int { get set }
     var startVirtualMachinesOnLaunch: Bool { get set }
     var gitHubPrivateKeyName: String? { get set }
+    var gitHubRunnerDisableUpdates: Bool { get set }
     var gitHubRunnerLabels: String { get set }
     var gitHubRunnerGroup: String { get set }
     var githubRunnerScope: GitHubRunnerScope { get set }

Packages/Settings/Sources/SettingsUI/Internal/GitHubRunnerSettings/GitHubRunnerSettingsView.swift

@@ -26,6 +26,13 @@ struct GitHubRunnerSettingsView<SettingsStoreType: SettingsStore & Observable>:
                 )
                 .disabled(!isSettingsEnabled)
             }
+            Section {
+                Toggle(isOn: $settingsStore.gitHubRunnerDisableUpdates) {
+                    Text(L10n.Settings.GithubRunner.disableUpdates)
+                    Text(L10n.Settings.GithubRunner.DisableUpdates.subtitle)
+                }
+                .disabled(!isSettingsEnabled)
+            }
         }
         .formStyle(.grouped)
     }

Packages/Settings/Sources/SettingsUI/Internal/L10n.swift

@@ -85,10 +85,16 @@ internal enum L10n {
       }
     }
     internal enum GithubRunner {
+      /// Disable runner auto-update
+      internal static let disableUpdates = L10n.tr("Localizable", "settings.github_runner.disableUpdates", fallback: "Disable runner auto-update")
       /// Group
       internal static let group = L10n.tr("Localizable", "settings.github_runner.group", fallback: "Group")
       /// Labels
       internal static let labels = L10n.tr("Localizable", "settings.github_runner.labels", fallback: "Labels")
+      internal enum DisableUpdates {
+        /// This is meant to be used when a fixed version is pre-installed, otherwise Tartelet will install the latest version when the VM starts.
+        internal static let subtitle = L10n.tr("Localizable", "settings.github_runner.disableUpdates.subtitle", fallback: "This is meant to be used when a fixed version is pre-installed, otherwise Tartelet will install the latest version when the VM starts.")
+      }
       internal enum Group {
         /// acme
         internal static let prompt = L10n.tr("Localizable", "settings.github_runner.group.prompt", fallback: "acme")

Packages/Settings/Sources/SettingsUI/Internal/Localizable.strings

@@ -41,6 +41,8 @@
 "settings.github.create_app" = "Create GitHub App";
 
 "settings.github_runner" = "Runner";
+"settings.github_runner.disableUpdates" = "Disable runner auto-update";
+"settings.github_runner.disableUpdates.subtitle" = "This is meant to be used when a fixed version is pre-installed, otherwise Tartelet will install the latest version when the VM starts.";
 "settings.github_runner.labels" = "Labels";
 "settings.github_runner.labels.prompt" = "comma,separated,list";
 "settings.github_runner.labels.footer" = "Comma-separated list of labels.";

Packages/VirtualMachine/Sources/VirtualMachineDomain/GitHubActionsRunner/GitHubActionsRunnerConfiguration.swift

@@ -1,6 +1,7 @@
 import GitHubDomain
 
 public protocol GitHubActionsRunnerConfiguration {
+    var runnerDisableUpdates: Bool { get }
     var runnerScope: GitHubRunnerScope { get }
     var runnerLabels: String { get }
     var runnerGroup: String { get }

Packages/VirtualMachine/Sources/VirtualMachineDomain/GitHubActionsRunner/GitHubActionsRunnerSSHConnectionHandler.swift

@@ -107,7 +107,8 @@ cd \\$ACTIONS_RUNNER_DIRECTORY
   --name "\(virtualMachine.name)"\\\\
   --runnergroup "\(configuration.runnerGroup)"\\\\
   --work "_work"\\\\
-  --token "\(runnerToken.rawValue)"
+  --token "\(runnerToken.rawValue)"\\\\
+  \(configuration.runnerDisableUpdates ? "--disableupdate" : "")
 ./run.sh
 EOF
 """)

Tartelet/Sources/SettingsGitHubActionsRunnerConfiguration.swift

@@ -6,6 +6,9 @@ struct SettingsGitHubActionsRunnerConfiguration<
     SettingsStoreType: SettingsStore
 >: GitHubActionsRunnerConfiguration {
     let settingsStore: SettingsStoreType
+    var runnerDisableUpdates: Bool {
+        settingsStore.gitHubRunnerDisableUpdates
+    }
     var runnerScope: GitHubRunnerScope {
         settingsStore.githubRunnerScope
     }