Skip to content

fix: Mixed clear/encrypted playback on Safari MSE #8354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Apr 3, 2025

Conversation

tykus160
Copy link
Member

Fixes #8335

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release browser: Safari Issues affecting Safari or WebKit derivatives labels Mar 28, 2025
@tykus160 tykus160 added this to the v4.15 milestone Mar 28, 2025
@tykus160 tykus160 requested review from joeyparrish and avelad March 28, 2025 12:25
@shaka-bot
Copy link
Collaborator

shaka-bot commented Mar 28, 2025

Incremental code coverage: 95.52%

@tykus160 tykus160 requested a review from avelad March 28, 2025 16:48
@avelad
Copy link
Member

avelad commented Mar 28, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8354

@tykus160
Copy link
Member Author

tykus160 commented Apr 2, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=8354

@avelad
Copy link
Member

avelad commented Apr 2, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8354

@tykus160
Copy link
Member Author

tykus160 commented Apr 3, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=8354

@tykus160 tykus160 requested review from avelad and gkatsev April 3, 2025 09:39
@tykus160
Copy link
Member Author

tykus160 commented Apr 3, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=8354

@tykus160 tykus160 merged commit 5f18231 into shaka-project:main Apr 3, 2025
57 of 62 checks passed
@tykus160 tykus160 deleted the wt-safari-fix branch April 3, 2025 13:01
avelad added a commit that referenced this pull request Apr 4, 2025
Fixes #8335

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
Co-authored-by: Gary Katsevman <[email protected]>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 2, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: Safari Issues affecting Safari or WebKit derivatives priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mixed encrypted/clear fairplay audio content fails on append
4 participants