Skip to content

[java] update property name #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 18, 2024
Merged

[java] update property name #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ace8770
[java] update property name
titusfortner Sep 16, 2024
4e2b1ee
didn't clear the correct property in tests
titusfortner Sep 16, 2024
37d4056
[java] allow users to disable sauce with environment variable as well…
titusfortner Sep 18, 2024
fa57d37
[java] run example files separately from tests
titusfortner Sep 18, 2024
1bda379
remove unused import
titusfortner Sep 18, 2024
4c78d44
remove execution mode which did not work as desired
titusfortner Sep 18, 2024
4f39f5d
remove comments that are no longer needed
titusfortner Sep 18, 2024
ae90c8d
[java] isDisabled set public and static to access from static context
titusfortner Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/main/src/main/java/com/saucelabs/saucebindings/SauceSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,6 @@ private void validateMac(String msg) {
}

private boolean isDisabled() {
return Objects.equals(System.getProperty("saucelabs"), "false");
return Objects.equals(System.getProperty("sauce.disabled"), "true");
}
}
3 changes: 2 additions & 1 deletion java/main/src/test/java/com/saucelabs/saucebindings/examples/DisableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class DisableTest {
@Test
public void startSession() {
// 1. Toggle off sauce labs
System.setProperty("saucelabs", "false");
System.setProperty("sauce.disabled", "true");

// 2. Create a Sauce Session
SauceSession session = new SauceSession();
Expand All @@ -22,6 +22,7 @@ public void startSession() {
Assertions.assertNull(driver);

// 4. All session commands will be ignored
Assertions.assertNull(session.getDriver());
Assertions.assertDoesNotThrow(
() -> {
session.annotate("This gets ignored");
Expand Down
Loading