Skip to content

[java] update property name #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 18, 2024
Merged

[java] update property name #320

merged 8 commits into from
Sep 18, 2024

Conversation

titusfortner
Copy link
Collaborator

@titusfortner titusfortner commented Sep 16, 2024

One-line summary

Rename toggle property to be more descriptive

Description

To toggle off Sauce code, set sauce.disabled to "true" rather than using saucelabs to "false"

Types of Changes

  • Refactor/improvements

Updates:

  • Allow disabling with environment variable as well as system property
  • Rename Examples from *Test.java to *Example.java
  • Run Examples sequentially after Tests to keep system property from propagating to other tests

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some tests failing.

@nadvolod
Copy link
Contributor

@titusfortner do we need an acceptance test that validates that this behavior works as expected? I remember that you had concerns. I also see a bunch of //TODO in the ToggleLocalExample.java

@nadvolod nadvolod merged commit 5d2ca1b into main Sep 18, 2024
8 checks passed
@nadvolod nadvolod deleted the rename_prop branch September 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants