terraform-alpine: Install terraform into $PATH #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative paths like 'terraform' are expanded form the current working directory anyway, so we don't need this extra command substitution.
Installing it without the leading slash makes invoking terraform via this container more like invoking terraform installed locally on the host system (e.g. via a package manager).
Alpine already has a /tmp and we don't need to preserve content terraform writes to /tmp, so there's no need to mount the host's /tmp into the container.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 14, 2018
0.11.8 was cut on 2018-08-15 [1,2]. Removing the leading slash is because with v0.11.8, terraform-alpine is dropping the terraform binary into the PATH [3,4,5]. [1]: https://github.com/hashicorp/terraform/releases/tag/v0.11.8 [2]: https://releases.hashicorp.com/terraform/0.11.8/ [3]: sallyom/scripts-images#3 [4]: sallyom/scripts-images@7221114 [5]: openshift#218 (comment)
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Sep 14, 2018
0.11.8 was cut on 2018-08-15 [1,2]. The image bump moved the terraform binary into the container's PATH with sallyom/scripts-images@931c8ee8 (terraform-alpine: Install terraform into $PATH, 2018-08-16, sallyom/scripts-images#3), but the installer's tf-fmt.sh was updated to match in openshift/installer@00323486 (Bump Terraform from 0.11.7 to 0.11.8, 2018-06-09, openshift/installer#218). Bumping the image here depends on using that bumped version of tf-fmt.sh. [1]: https://github.com/hashicorp/terraform/releases/tag/v0.11.8 [2]: https://releases.hashicorp.com/terraform/0.11.8/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1; review that first.
Installing it without the leading slash makes invoking terraform via this container more like invoking terraform installed locally on the host system (e.g. via a package manager).