Skip to content

Bump Terraform from 0.11.7 to 0.11.8 #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2018
Merged

Bump Terraform from 0.11.7 to 0.11.8 #1515

merged 1 commit into from
Sep 17, 2018

Conversation

wking
Copy link
Member

@wking wking commented Sep 14, 2018 •
edited
Loading

0.11.8 was cut on 2018-08-15.

The image bump moved the terraform binary into the container's PATH with sallyom/scripts-images@931c8ee8 (sallyom/scripts-images#3), but the installer's tf-fmt.sh was updated to match in openshift/installer#218. Bumping the image here depends on using that bumped version of tf-fmt.sh.

/hold

We need openshift/installer#218 to land before this.

@wking
Bump Terraform from 0.11.7 to 0.11.8
bbb02d3 
0.11.8 was cut on 2018-08-15 [1,2].

The image bump moved the terraform binary into the container's PATH
with sallyom/scripts-images@931c8ee8 (terraform-alpine: Install
terraform into $PATH, 2018-08-16, sallyom/scripts-images#3), but the
installer's tf-fmt.sh was updated to match in
openshift/installer@00323486 (Bump Terraform from 0.11.7 to 0.11.8,
2018-06-09, openshift/installer#218).  Bumping the image here depends
on using that bumped version of tf-fmt.sh.

[1]: https://github.com/hashicorp/terraform/releases/tag/v0.11.8
[2]: https://releases.hashicorp.com/terraform/0.11.8/
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2018
wking added a commit to wking/openshift-installer that referenced this pull request Sep 14, 2018
@wking
hack/tf-fmt: Add a workaround for origin/release's hardcoding v0.11.7
856350d 
We'll want to revert this once we bump [1] to point to the new image.
I've filed [2] with that bump.

[1]: https://github.com/openshift/release/blob/4ea9040eeb4131730af491d2feb926a889a0bd62/ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml#L281
[2]: openshift/release#1515
@wking wking mentioned this pull request Sep 14, 2018
Merged
@wking
Copy link
Member Author

wking commented Sep 17, 2018

openshift/installer#218 landed.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2018
@wking wking mentioned this pull request Sep 17, 2018
Merged
wking added a commit to wking/openshift-installer that referenced this pull request Sep 17, 2018
@wking
Revert "hack/tf-fmt: Add a workaround for origin/release's hardcoding…
4e9612d 
… v0.11.7"

This reverts commit 856350d, openshift#218.

openshift/release@bbb02d36 (Bump Terraform from 0.11.7 to 0.11.8,
2018-09-14, openshift/release#1515) has landed, so we can drop the
workaround.
crawford
crawford reviewed Sep 17, 2018
View reviewed changes
Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 038669c into openshift:master Sep 17, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the job-config configmap using the following files:

  • key openshift-installer-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml

In response to this:

0.11.8 was cut on 2018-08-15.

The image bump moved the terraform binary into the container's PATH with sallyom/scripts-images@931c8ee8 (sallyom/scripts-images#3), but the installer's tf-fmt.sh was updated to match in openshift/installer#218. Bumping the image here depends on using that bumped version of tf-fmt.sh.

/hold

We need openshift/installer#218 to land before this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the installer-terraform-0.11.8 branch September 17, 2018 19:15
derekhiggins added a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@derekhiggins
Update dev-scripts CI image (openshift#1515)
3fdd32a 
We temporarily need to support both RHEL 7 and 8
as we can't change the ci-operator image build to switch
to rhel a new image in lockstep. Once the switch over is done
we can remove the RHEL7 support.

This should allow use to eventually remove the NSS_WRAPPER_PASSWD
hack in baremetalds-packet-setup-commands.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford crawford left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@crawford crawford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @openshift-ci-robot @crawford @openshift-merge-robot