feat: function to calculate min fee in wei for a given stream ID #1270
+73
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
chore/fee-getters
branch
from
16d0d0b to
68f2d7b
Compare
andreivladbrg
force-pushed
the
refactor/ComptrollerManager
branch
3 times, most recently
from
11773f4 to
b5c157c
Compare
andreivladbrg
force-pushed
the
chore/fee-getters
branch
from
5d5aa64 to
5691b30
Compare
smol-ninja
commented
Jul 9, 2025
smol-ninja
force-pushed
the
refactor/ComptrollerManager
branch
from
3b49c5b to
d915e5e
Compare
refactor: use the new function to calculate min fee in wei test: add integration test for calculateMinFeeWei
smol-ninja
force-pushed
the
chore/fee-getters
branch
from
5691b30 to
3c0dcd8
Compare
andreivladbrg
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to sablier-labs/evm-utils#44.
Depends on #1268.
Note
The new function
calculateMinFeeWeiis added to Lockup contract because it would be useful for external contracts to query fee for a given stream ID from the Lockup contract itself and then use the returned value in the withdraw function. Without the function, they will have to query it from comptroller using stream's sender and then use that value in withdraw function - a poor UX.This PR also resolves Cantina finding 19.