Skip to content

refactor: ComptrollerManager to Comptrollerable #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2025

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Jul 6, 2025

@smol-ninja smol-ninja marked this pull request as draft July 6, 2025 10:42
@smol-ninja smol-ninja marked this pull request as ready for review July 7, 2025 09:18
@andreivladbrg
Copy link
Member

haven't reviewed it, but let's wait first to merge the evm-utils PR into main

@smol-ninja
Copy link
Member Author

Yes. I would prefer all the evm-utils PR to be merged first before merging any of the Lockup PRs.

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andreivladbrg andreivladbrg force-pushed the refactor/ComptrollerManager branch 3 times, most recently from d6da0a5 to 11773f4 Compare July 9, 2025 20:40
@andreivladbrg andreivladbrg force-pushed the refactor/ComptrollerManager branch from 11773f4 to b5c157c Compare July 9, 2025 20:51
@smol-ninja smol-ninja force-pushed the refactor/ComptrollerManager branch from 132618f to 3b49c5b Compare July 9, 2025 21:41
@smol-ninja smol-ninja force-pushed the refactor/ComptrollerManager branch from 3b49c5b to d915e5e Compare July 9, 2025 21:44
@smol-ninja
Copy link
Member Author

Thanks for the review @andreivladbrg. I am going to merge it now.

@smol-ninja smol-ninja merged commit f70a2bd into staging Jul 9, 2025
9 checks passed
@smol-ninja smol-ninja deleted the refactor/ComptrollerManager branch July 9, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants