-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bugfix/date arg types #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bugfix/date arg types #1684
Conversation
Notice that other methods such as |
Noted, going through and updating the rest of the methods. Update should be ready shortly. |
Thanks! FWIW as-is this is a breaking change so we won't be able to merge this quite just yet, we're still in the process of batching breaking changes. If you'd prefer though perhaps new methods with new names could be added, and then in the next major version release we can delete all the methods and change the existing signatures? |
Added the other updates. @alexcrichton I think holding off and batching these with other breaking changes makes sense. Also worth noting the above commits didn't include the setFullYear and setUTCFullYear as support for optional parameters have not yet been implemented. It might make more sense to include that with #1664 for overall optional param support. |
Ok sounds good to me! I'll tag this as a breaking change and we'll merge this when we get to doing the next round of breaking changes. |
Addresses #1662