Skip to content

Date methods missing support for negative arguments #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ghost opened this issue Jul 13, 2019 · 1 comment
Open

Date methods missing support for negative arguments #1662

ghost opened this issue Jul 13, 2019 · 1 comment
Labels
help wanted We could use some help fixing this issue! js-sys Issues related to the `js-sys` crate

Comments

@ghost
Copy link

ghost commented Jul 13, 2019

Methods of the Date object such as setDate officially allow negative arguments, but this isn't currently supported by web-sys.
@ghost ghost added the bug Something isn't working label Jul 13, 2019
@alexcrichton alexcrichton added help wanted We could use some help fixing this issue! js-sys Issues related to the `js-sys` crate and removed bug Something isn't working labels Jul 15, 2019
@cburgos
Copy link
Contributor

cburgos commented Jul 30, 2019 •
edited
Loading

Is this still available? If so I would like to take a stab at it. Initially my thinking is this is just a type update for the affected methods which should be straightforward.

@cburgos cburgos mentioned this issue Jul 30, 2019
Open
@cburgos cburgos mentioned this issue Sep 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We could use some help fixing this issue! js-sys Issues related to the `js-sys` crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @cburgos