Switch from ring to openssl #394
Conversation
|
@bors r+ |
|
📌 Commit 7b58b55 has been approved by |
Switch from ring to openssl The ring update policy is awful (see briansmith/ring#774), so this switches to a crate that doesn't break existing builds every time a new version is released.
|
💔 Test failed - status-appveyor |
pietroalbini
force-pushed
the
remove-ring
branch
from
7b58b55 to
64c665e
Compare
|
@bors r+ |
|
📌 Commit 64c665e has been approved by |
Switch from ring to openssl The ring update policy is awful (see the ring repo), so this switches to a crate that doesn't break existing builds every time a new version is released.
|
💔 Test failed - status-appveyor |
pietroalbini
force-pushed
the
remove-ring
branch
from
64c665e to
4d056e2
Compare
|
@bors r+ |
|
📌 Commit 4d056e2 has been approved by |
Switch from ring to openssl The ring update policy is awful (see the ring repo), so this switches to a crate that doesn't break existing builds every time a new version is released.
pietroalbini
force-pushed
the
remove-ring
branch
from
4d056e2 to
f35ed45
Compare
|
@bors p=1 retry r+ |
|
📌 Commit f35ed45 has been approved by |
Switch from ring to openssl The ring update policy is awful (see briansmith/ring#774), so this switches to a crate that doesn't break existing builds every time a new version is released.
|
☀️ Test successful - checks-travis, status-appveyor |
My understanding is that crates can still depend on yanked crates, based on the discussion in rust-lang/cargo#4111, so my policy shouldn't result in any broken builds, AFAICT. If that's not the case then I think that's a bug in cargo that needs to be resolved. Definitely I never intended to break anybody's builds; at most I expected people to get warnings about depending on a yanked crate. |
Builds with a lockfile will indeed continue to work as long as the lockfile is present, but Cargo will refuse to update any dependency until the yanked one is removed from the dependency tree, blocking the development. Left a more detailed reply in briansmith/ring#774 (comment). |
I believe that's a bug: rust-lang/cargo#6609 |
The ring update policy is awful (see briansmith/ring#774), so this switches to a crate that doesn't break existing builds every time a new version is released.