Skip to content

Reconsider yanking policy #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pheki opened this issue Oct 22, 2021 · 2 comments
Closed

Reconsider yanking policy #3

pheki opened this issue Oct 22, 2021 · 2 comments

Comments

@pheki
Copy link
Contributor

pheki commented Oct 22, 2021

I've noticed you have yanked all older versions of monocypher-rs, but this is not always considered a good practice in rust.

ring used to do it, but it caused lots of discussions, resulting in rust-lang/crater moving from ring to openssl (rust-lang/crater#394) and ring starting yanking only known-vulnerable versions. See this comment from pietroalbini (member of many rust teams). It's a bit subjective, but my personal opinion is similar, crates should be yanked only when there's a semver compatible release available.

Related discussions:

On an unrelated notes, I'm contributing a little to this crate but I don't wish to give too much maintenance burden, sorry if I am...

@jan-schreib
Copy link
Owner

Yes, at the time I thought it is a good idea. You are correct though, when releasing a new version I will not continue to yank the old ones.

Thanks for bringing this up!

On an unrelated notes, I'm contributing a little to this crate but I don't wish to give too much maintenance burden, sorry if I am...

Don't worry about it, I'm happy when people are participating in a productiv way.

@pheki
Copy link
Contributor Author

pheki commented Oct 28, 2021

Well, it's so hard to know what are the current best practices, I think I only know about this because I've been bitten by the transitive yanked ring before ;)

@pheki pheki closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants