Set APPEND_PROJECT_NAME_TO_INCLUDEDIR to ON #629
Conversation
|
@sloretz is this a CMake argument which should be added to the bloom patches for packaging as well? edited for clarity |
Definitely, though I don't know how to do that. Willing to teach me? I opened an issue here: ros2-gbp/fastcdr-release#9 |
@nuclearsandwich Would you be willing to review these PRs updating the debian and rpm rules on the release repos for Fast-CDR, Fast-DDS, and Cyclone-DDS? ros2-gbp/fastcdr-release#10 |
|
CI (build and test all, but with this CI scripts branch)
|
eProsima/Fast-DDS#2535 eProsima/Fast-CDR#120 This is in support of ros2/ros2#1150 Signed-off-by: Shane Loretz <[email protected]>
sloretz
force-pushed
the
set_APPEND_PROJECT_NAME_TO_INCLUDEDIR
branch
from
8c3f480 to
4f5795f
Compare
|
Rebased and Trying CI again:
|
|
CI LGTM Linux and windows jobs have test failures, however the important thing is all packages built. This change should only affect where headers are found. The linux test failures appear the same as the last nightly: https://ci.ros2.org/view/nightly/job/nightly_linux_release/2233/#showFailuresLink The windows failures are known flaky tests in |
Yes, those should be fixed by #648 (you just happened to run CI before that was merged).
Yes, absolutely. This looks good to me, I'll add another approval. |
delete-merged-branch
bot
deleted the
set_APPEND_PROJECT_NAME_TO_INCLUDEDIR
branch
eProsima/Fast-DDS#2535
eProsima/Fast-CDR#120
eclipse-cyclonedds/cyclonedds#1169
This is in support of ros2/ros2#1150
Signed-off-by: Shane Loretz [email protected]