Skip to content

Set APPEND_PROJECT_NAME_TO_INCLUDEDIR to ON #9 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2022
Merged

Set APPEND_PROJECT_NAME_TO_INCLUDEDIR to ON #9 #10

merged 1 commit into from
Mar 21, 2022

Conversation

sloretz
Copy link

@sloretz sloretz commented Mar 21, 2022

@sloretz sloretz self-assigned this Mar 21, 2022
@sloretz sloretz mentioned this pull request Mar 21, 2022
Merged
clalancette
clalancette approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, so approving. Feel free to merge this. However, I'll suggest not doing a release of this package right now. We need to update this package to the newest version (0.9.x) anyway, so let's just do a new release that has both of these in place.

@sloretz sloretz merged commit 32f9f40 into rpm/rolling/cyclonedds Mar 21, 2022
@sloretz sloretz deleted the sloretz_cyclonedds_rpm_unique_include branch March 21, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@cottsay cottsay cottsay approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

@audrow audrow Awaiting requested review from audrow

Assignees

@sloretz sloretz

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @clalancette @cottsay