-
Notifications
You must be signed in to change notification settings - Fork 348
Add deprecations to old methods not using Structs #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecations to old methods not using Structs #2344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes. on a side note, should the template function for initialize_hardware in RM also have deprecation warning
Co-authored-by: Soham Patil <[email protected]>
I'll open another PR for the cleanup. The scope of this PR is only upto deprecations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just that one file remaining, rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit abbf8d6) # Conflicts: # hardware_interface/include/hardware_interface/actuator_interface.hpp # hardware_interface/include/hardware_interface/resource_manager.hpp # hardware_interface/include/hardware_interface/sensor_interface.hpp # hardware_interface/include/hardware_interface/system_interface.hpp
This PR adds deprecations to the old methods