Skip to content

Move enforce_command_limits parameter to GPL parameters (backport #2305) #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 5, 2025

This PR moves the parameter declared in the code that works for older and newer versions to GPL parameters list.

When this PR is backported, the default parameter could be changed to false


This is an automatic backport of pull request #2305 done by Mergify.

(cherry picked from commit 2c691e0)

# Conflicts:
#	controller_manager/src/controller_manager_parameters.yaml
Copy link
Contributor Author

mergify bot commented Jun 5, 2025

Cherry-pick of 2c691e0 has failed:

On branch mergify/bp/jazzy/pr-2305
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 2c691e0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/doc/userdoc.rst
	modified:   controller_manager/include/controller_manager/controller_manager.hpp
	modified:   controller_manager/src/controller_manager.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/controller_manager_parameters.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 5, 2025
@saikishor
Copy link
Member

I'll leave it to you @bmagyar ;)

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.61%. Comparing base (6ea0064) to head (b62a695).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2316      +/-   ##
==========================================
- Coverage   88.70%   88.61%   -0.10%     
==========================================
  Files         143      143              
  Lines       16510    16508       -2     
  Branches     1429     1427       -2     
==========================================
- Hits        14646    14628      -18     
- Misses       1316     1332      +16     
  Partials      548      548              
Flag Coverage Δ
unittests 88.61% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 96.87% <ø> (ø)
controller_manager/src/controller_manager.cpp 74.24% <0.00%> (-0.30%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor merged commit c079105 into jazzy Jun 5, 2025
13 of 14 checks passed
@saikishor saikishor deleted the mergify/bp/jazzy/pr-2305 branch June 5, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants