-
Notifications
You must be signed in to change notification settings - Fork 348
Cleanup deprecations in ros_control
#2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup deprecations in ros_control
#2258
Conversation
43dfac8
to
0e7e7e6
Compare
@christophfroehlich we can continue with this one, and I will progressively open more PRs in the upcoming days that might need changes merged in other ros-controls repos at similar time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Should we copy/readd the migration notes of the handles kilted version, or do we leave them in the jazzy-version? (the users fault if they ignored the warnings earlier)
I would say it is not needed as it is rolling and the deprecations were already present for some time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2258 +/- ##
==========================================
- Coverage 88.95% 88.92% -0.03%
==========================================
Files 143 143
Lines 16458 16435 -23
Branches 1424 1422 -2
==========================================
- Hits 14640 14615 -25
- Misses 1266 1267 +1
- Partials 552 553 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
but also on kilted ;) |
7f0bd68
into
ros-controls:master
This PR aims to do a deprecations cleanup in the ros2_control packages