Skip to content

Cleanup deprecations in ros_control #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saikishor
Copy link
Member

This PR aims to do a deprecations cleanup in the ros2_control packages

@saikishor saikishor force-pushed the cleanup/deprecations branch from 43dfac8 to 0e7e7e6 Compare May 20, 2025 13:08
@saikishor
Copy link
Member Author

@christophfroehlich we can continue with this one, and I will progressively open more PRs in the upcoming days that might need changes merged in other ros-controls repos at similar time

@saikishor saikishor marked this pull request as ready for review May 21, 2025 10:45
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Should we copy/readd the migration notes of the handles kilted version, or do we leave them in the jazzy-version? (the users fault if they ignored the warnings earlier)

@saikishor
Copy link
Member Author

This is great. Should we copy/readd the migration notes of the handles kilted version, or do we leave them in the jazzy-version? (the users fault if they ignored the warnings earlier)

I would say it is not needed as it is rolling and the deprecations were already present for some time

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (25a9c63) to head (2d65828).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2258      +/-   ##
==========================================
- Coverage   88.95%   88.92%   -0.03%     
==========================================
  Files         143      143              
  Lines       16458    16435      -23     
  Branches     1424     1422       -2     
==========================================
- Hits        14640    14615      -25     
- Misses       1266     1267       +1     
- Partials      552      553       +1     
Flag Coverage Δ
unittests 88.92% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...interface/include/controller_interface/helpers.hpp 61.53% <ø> (ø)
controller_manager/controller_manager/spawner.py 71.52% <100.00%> (-2.37%) ⬇️
controller_manager/test/test_spawner_unspawner.cpp 96.11% <ø> (-0.16%) ⬇️
.../include/hardware_interface/actuator_interface.hpp 90.96% <ø> (ø)
...re_interface/include/hardware_interface/handle.hpp 91.17% <ø> (ø)
...de/hardware_interface/loaned_command_interface.hpp 52.50% <ø> (ø)
...lude/hardware_interface/loaned_state_interface.hpp 60.00% <ø> (ø)
...ce/include/hardware_interface/sensor_interface.hpp 85.00% <ø> (ø)
...ce/include/hardware_interface/system_interface.hpp 84.26% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich
Copy link
Contributor

This is great. Should we copy/readd the migration notes of the handles kilted version, or do we leave them in the jazzy-version? (the users fault if they ignored the warnings earlier)

I would say it is not needed as it is rolling and the deprecations were already present for some time

but also on kilted ;)

@christophfroehlich christophfroehlich merged commit 7f0bd68 into ros-controls:master May 21, 2025
22 of 31 checks passed
@christophfroehlich christophfroehlich deleted the cleanup/deprecations branch May 21, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants