Skip to content

Add deprecated get_optional to Transmission Handle #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saikishor
Copy link
Member

With #2223 we recently reverted back to the old version of the Handles in the transmission interface, however, if the user code base uses the methods get_optional and std::ignore for the set_value, he/she will have compilation issues. In order to avoid such things, I'm adding these deprecated methods only to Jazzy, so their pipelines will continue to work

@saikishor saikishor changed the title Add deprecated get_optional to Transmission Handle Add deprecated get_optional to Transmission Handle May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (e84100a) to head (4b65b3e).
Report is 2 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2255      +/-   ##
==========================================
+ Coverage   88.70%   88.71%   +0.01%     
==========================================
  Files         143      143              
  Lines       16437    16434       -3     
  Branches     1424     1424              
==========================================
- Hits        14581    14580       -1     
+ Misses       1311     1310       -1     
+ Partials      545      544       -1     
Flag Coverage Δ
unittests 88.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nterface/include/transmission_interface/handle.hpp 91.66% <100.00%> (+5.00%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit d5a9fae into ros-controls:jazzy May 19, 2025
13 checks passed
@christophfroehlich christophfroehlich deleted the add/get_optional/transmissions branch May 19, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants