-
Notifications
You must be signed in to change notification settings - Fork 349
Add new Handle
constructor for easier initialization
#2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Handle
constructor for easier initialization
#2253
Conversation
e5ff0c6
to
40811c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2253 +/- ##
==========================================
- Coverage 88.92% 88.92% -0.01%
==========================================
Files 143 143
Lines 16436 16454 +18
Branches 1422 1422
==========================================
+ Hits 14615 14631 +16
- Misses 1268 1270 +2
Partials 553 553
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor requests only
Right now, when we add new tests, we will have to generate the
InterfaceInfo
for each state and command interface, and this is nothing but increasing the lines of code. I've added a new constructor that we can use inside the testsPrevious approach
New approach: