-
Notifications
You must be signed in to change notification settings - Fork 350
Add data_type
field to the HardwareInterfaces message (backport #2204)
#2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cherry-pick of 0c7cb99 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jazzy #2232 +/- ##
========================================
Coverage ? 88.58%
========================================
Files ? 142
Lines ? 16490
Branches ? 1430
========================================
Hits ? 14608
Misses ? 1329
Partials ? 553
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross-checking: ABI break is fine?
failing docs get fixed with #2241
I guess so |
The API changes are fine because only internal, but we break the message types used in the services. This is mostly used with CLI verbs I guess, but it might break users rosbags. @bmagyar any red flag in merging this? |
This is important for whatever else we'd like to land in Jazzy with Variants. |
This would be interesting to have when we extend the data types in the handles. Now, the CLI will also show the type of the interface, so it is much easier for the users to understand the types from a closed system. Below will be the output with these changes
This is an automatic backport of pull request #2204 done by [Mergify](https://mergify.com).