Skip to content

Add robot_description parameter to the controllers #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saikishor
Copy link
Member

This might be useful for all the controllers as well as for the Joint state broadcaster to have all the new features that we have recently added

Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (3cffec4) to head (3c6243a).
Report is 2 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2198      +/-   ##
==========================================
+ Coverage   63.67%   63.68%   +0.01%     
==========================================
  Files         112      112              
  Lines       12933    12937       +4     
  Branches     8738     8739       +1     
==========================================
+ Hits         8235     8239       +4     
  Misses        806      806              
  Partials     3892     3892              
Flag Coverage Δ
unittests 63.68% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 100.00% <ø> (ø)
controller_manager/src/controller_manager.cpp 66.80% <100.00%> (+0.05%) ⬆️
hardware_interface/src/resource_manager.cpp 79.15% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmagyar
Copy link
Member

bmagyar commented Apr 21, 2025

Wasn't this already there?

@saikishor
Copy link
Member Author

Wasn't this already there?

Seems like it is not there already, atleast I couldn't find it

@saikishor
Copy link
Member Author

After the discussion in yesterday's WG meeting, we have decided not to introduce such framework-wide changes into Humble. For this reason, I'll go ahead and close this PR.

@saikishor saikishor closed this Apr 24, 2025
@saikishor saikishor deleted the add/robot_description/parameter/humble branch April 24, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants