Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunspell support, dictionaries, update links #224

Merged
merged 16 commits into from
Apr 1, 2025

Conversation

funkill
Copy link
Contributor

@funkill funkill commented Nov 16, 2024

Added hunspell support for En, De, Es, Fr, Ru, Uk
Added aspess support for Ru, Uk
Changed os mnemonic version in packages links

@jonasbn jonasbn self-requested a review March 29, 2025 08:46
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @funkill

This looks great. I have one request for a change. Could you provide and example for the documentation for the INPUT_SPELL_CHECKER parameter.

@jonasbn
Copy link
Collaborator

jonasbn commented Mar 31, 2025

Hi @funkill

With the PR #234 approved

I believe it would be nice to output the version of hunspell as well as for aspell and pyspelling.

dependabot bot and others added 11 commits April 1, 2025 16:09
Bumps python from 3.13.0-slim-bookworm to 3.13.1-slim-bookworm.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nosborn/github-action-markdown-cli](https://github.com/nosborn/github-action-markdown-cli) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/nosborn/github-action-markdown-cli/releases)
- [Commits](nosborn/github-action-markdown-cli@v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: nosborn/github-action-markdown-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps python from 3.13.1-slim-bookworm to 3.13.2-slim-bookworm.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
* feat: add arm64 image

* ci: pin actions

* ci: add sha
@jonasbn
Copy link
Collaborator

jonasbn commented Apr 1, 2025

Hi @funkill

I did some testing of your PR and merged with the master branch to make sure I call all things covered.

  • Documentation has been updated with an example
  • hunspell now outputs version information
  • New parameter has been outlined in action.yml with GHA meta-data

In addition I added some more output.

@jonasbn jonasbn merged commit 5a7e4ea into rojopolis:master Apr 1, 2025
@jonasbn
Copy link
Collaborator

jonasbn commented Apr 1, 2025

@funkill about the action.yml you can see a warning here since the parameter is not published.

Spellcheck
Unexpected input(s) 'spell_checker', valid inputs are ['entryPoint', 'args', 'config_path', 'source_files', 'task_name', 'output_file']

Thank you very much for you contribution, I am sorry it took me so long to get around to reviewing it, but so little time and so much to do, see and try

@jonasbn
Copy link
Collaborator

jonasbn commented Apr 1, 2025

Here is an example from one of my test runs:

docker run -e INPUT_SOURCE_FILES="README.md CHANGELOG.md" \
           -e INPUT_TASK_NAME=Markdown -e INPUT_SPELL_CHECKER=hunspell -it -v $PWD:/tmp \
           jonasbn/github-action-spellcheck:local

Using pyspelling on configuration outlined in >spellcheck.yaml<
pyspelling 2.10
@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.8)
@(#) International Ispell Version 3.2.06 (but really Hunspell 1.7.1)


Copyright (C) 2002-2014 László Németh. License: MPL/GPL/LGPL.

Based on OpenOffice.org's Myspell library.
Myspell's copyright (C) Kevin Hendricks, 2001-2002, License: BSD.

This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
to the extent permitted by law.
----------------------------------------------------------------
Source files to check: >README.md CHANGELOG.md<
Running task >Markdown<
Checking file >README.md<
Checking file >CHANGELOG.md<
Checking files specification in sources_list as: > --source README.md --source CHANGELOG.md<
Using hunspell as spell checker via action configuration
Using hunspell to spellcheck Markdown
Running Task: Markdown...
Compiling Dictionary...
> Processing: README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants